From 2cc3f1753e899ce90cde8f9b7606e994220c0000 Mon Sep 17 00:00:00 2001 From: remoterami Date: Mon, 29 Jul 2024 12:11:43 +0200 Subject: [PATCH] comments adjusted --- backend/pkg/api/data_access/block.go | 9 +++++++++ backend/pkg/api/handlers/internal.go | 1 - backend/pkg/api/types/block.go | 2 +- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/backend/pkg/api/data_access/block.go b/backend/pkg/api/data_access/block.go index dc5f1b8ff..9a5c17f32 100644 --- a/backend/pkg/api/data_access/block.go +++ b/backend/pkg/api/data_access/block.go @@ -19,37 +19,46 @@ type BlockRepository interface { } func (d *DataAccessService) GetBlock(ctx context.Context, chainId, block uint64) (*t.BlockSummary, error) { + // @DATA-ACCESS return d.dummy.GetBlock(ctx, chainId, block) } func (d *DataAccessService) GetBlockOverview(ctx context.Context, chainId, block uint64) (*t.BlockOverview, error) { + // @DATA-ACCESS return d.dummy.GetBlockOverview(ctx, chainId, block) } func (d *DataAccessService) GetBlockTransactions(ctx context.Context, chainId, block uint64) ([]t.BlockTransactionTableRow, error) { + // @DATA-ACCESS return d.dummy.GetBlockTransactions(ctx, chainId, block) } func (d *DataAccessService) GetBlockVotes(ctx context.Context, chainId, block uint64) ([]t.BlockVoteTableRow, error) { + // @DATA-ACCESS return d.dummy.GetBlockVotes(ctx, chainId, block) } func (d *DataAccessService) GetBlockAttestations(ctx context.Context, chainId, block uint64) ([]t.BlockAttestationTableRow, error) { + // @DATA-ACCESS return d.dummy.GetBlockAttestations(ctx, chainId, block) } func (d *DataAccessService) GetBlockWithdrawals(ctx context.Context, chainId, block uint64) ([]t.BlockWithdrawalTableRow, error) { + // @DATA-ACCESS return d.dummy.GetBlockWithdrawals(ctx, chainId, block) } func (d *DataAccessService) GetBlockBlsChanges(ctx context.Context, chainId, block uint64) ([]t.BlockBlsChangeTableRow, error) { + // @DATA-ACCESS return d.dummy.GetBlockBlsChanges(ctx, chainId, block) } func (d *DataAccessService) GetBlockVoluntaryExits(ctx context.Context, chainId, block uint64) ([]t.BlockVoluntaryExitTableRow, error) { + // @DATA-ACCESS return d.dummy.GetBlockVoluntaryExits(ctx, chainId, block) } func (d *DataAccessService) GetBlockBlobs(ctx context.Context, chainId, block uint64) ([]t.BlockBlobTableRow, error) { + // @DATA-ACCESS return d.dummy.GetBlockBlobs(ctx, chainId, block) } diff --git a/backend/pkg/api/handlers/internal.go b/backend/pkg/api/handlers/internal.go index 6f714791d..8004b5fc9 100644 --- a/backend/pkg/api/handlers/internal.go +++ b/backend/pkg/api/handlers/internal.go @@ -2066,7 +2066,6 @@ func (h *HandlerService) InternalGetBlockTransactions(w http.ResponseWriter, r * returnOk(w, response) } -// WIP FROM HERE func (h *HandlerService) InternalGetBlockVotes(w http.ResponseWriter, r *http.Request) { chainId, block, err := h.validateBlockRequest(r) if err != nil { diff --git a/backend/pkg/api/types/block.go b/backend/pkg/api/types/block.go index 630f9e93f..5b3d071c2 100644 --- a/backend/pkg/api/types/block.go +++ b/backend/pkg/api/types/block.go @@ -203,7 +203,7 @@ type BlockBlobTableRow struct { Size uint64 `json:"size"` TransactionHash Hash `json:"transaction_hash"` Block uint64 `json:"block"` - Data []byte `json:"data"` + Data string `json:"data"` } type InternalGetBlockBlobsResponse ApiDataResponse[[]BlockBlobTableRow]