From f0174b17c0d9db31cfc8736fa3760a3abdc424d2 Mon Sep 17 00:00:00 2001
From: LUCCA DUKIC <109136188+LuccaBitfly@users.noreply.github.com>
Date: Wed, 2 Oct 2024 11:29:49 +0200
Subject: [PATCH] refactor: move response wrapping func to utils See: BEDS-481

---
 .../dashboard/table/DashboardTableRewards.vue | 20 +++++--------------
 frontend/utils/wrapWithIdentifier.ts          | 19 ++++++++++++++++++
 2 files changed, 24 insertions(+), 15 deletions(-)
 create mode 100644 frontend/utils/wrapWithIdentifier.ts

diff --git a/frontend/components/dashboard/table/DashboardTableRewards.vue b/frontend/components/dashboard/table/DashboardTableRewards.vue
index 92758a883..c86e377ed 100644
--- a/frontend/components/dashboard/table/DashboardTableRewards.vue
+++ b/frontend/components/dashboard/table/DashboardTableRewards.vue
@@ -137,19 +137,6 @@ const findNextEpochDuties = (epoch: number) => {
 
   return list.join(', ')
 }
-
-const wrappedRewards = computed(() => {
-  if (!rewards.value) {
-    return
-  }
-  return {
-    data: rewards.value.data.map(d => ({
-      ...d,
-      identifier: `${d.epoch}-${d.group_id}`,
-    })),
-    paging: rewards.value.paging,
-  }
-})
 </script>
 
 <template>
@@ -168,8 +155,11 @@ const wrappedRewards = computed(() => {
       <template #table>
         <ClientOnly fallback-tag="span">
           <BcTable
-            :data="wrappedRewards"
-            data-key="identifier"
+            :data="wrapWithIdentifier(
+              rewards,
+              row => `${row.epoch}-${row.group_id}`,
+            )"
+            data-key="wrapped_identifier"
             :expandable="true"
             class="rewards-table"
             :cursor
diff --git a/frontend/utils/wrapWithIdentifier.ts b/frontend/utils/wrapWithIdentifier.ts
new file mode 100644
index 000000000..4bbee8340
--- /dev/null
+++ b/frontend/utils/wrapWithIdentifier.ts
@@ -0,0 +1,19 @@
+import type { ApiPagingResponse } from '~/types/api/common'
+/**
+ * This function wraps each element in an `ApiPagingResponse` interface with a unique id field `wrapped_identifier`.
+ * @param response The api response to wrap
+ * @param getIdFromRow A function that takes a row and builds a unique identifier
+ * @returns The wrapped response
+ */
+export function wrapWithIdentifier<T>(response: ApiPagingResponse<T> | undefined, getIdFromRow: (row: T) => string) {
+  if (!response) {
+    return
+  }
+  return {
+    data: response.data.map(row => ({
+      ...row,
+      wrapped_identifier: getIdFromRow(row),
+    })),
+    paging: response.paging,
+  }
+}