From b8cc020b0879b50dbc07f528deeb3a527d5d294a Mon Sep 17 00:00:00 2001 From: MarcelBitfly <174338434+marcel-bitfly@users.noreply.github.com> Date: Thu, 12 Sep 2024 15:32:17 +0200 Subject: [PATCH 1/7] refactor: rename `css class` screenreader only --- frontend/assets/css/main.scss | 2 +- frontend/components/bc/BcButtonIcon.vue | 2 +- frontend/components/bc/BcContentFilter.vue | 2 +- frontend/components/notifications/NotificationsOverview.vue | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/frontend/assets/css/main.scss b/frontend/assets/css/main.scss index e551aa1fd..62033acc7 100644 --- a/frontend/assets/css/main.scss +++ b/frontend/assets/css/main.scss @@ -98,7 +98,7 @@ svg { } // see https://tailwindcss.com/docs/screen-readers -sr-only { +.bc-screenreader-only { position: absolute; width: 1px; height: 1px; diff --git a/frontend/components/bc/BcButtonIcon.vue b/frontend/components/bc/BcButtonIcon.vue index 1c7983241..9c3c0f1fa 100644 --- a/frontend/components/bc/BcButtonIcon.vue +++ b/frontend/components/bc/BcButtonIcon.vue @@ -10,7 +10,7 @@ const props = defineProps<{ diff --git a/frontend/components/bc/BcContentFilter.vue b/frontend/components/bc/BcContentFilter.vue index edd6e4038..ace2540fc 100644 --- a/frontend/components/bc/BcContentFilter.vue +++ b/frontend/components/bc/BcContentFilter.vue @@ -58,7 +58,7 @@ const handleClick = () => { :class="{ filter_visible: isFilterVisible }" @click="handleClick" > - + {{ !isFilterVisible ? $t('filter.open') : $t('filter.close') }} diff --git a/frontend/components/notifications/NotificationsOverview.vue b/frontend/components/notifications/NotificationsOverview.vue index 67699e90e..925752e66 100644 --- a/frontend/components/notifications/NotificationsOverview.vue +++ b/frontend/components/notifications/NotificationsOverview.vue @@ -100,7 +100,7 @@ const emit = defineEmits<{ {{ $t('notifications.overview.headers.most_notifications_30d') }}
-

+

{{ $t('notifications.overview.headers.validator_groups') }}

    @@ -112,7 +112,7 @@ const emit = defineEmits<{
-

+

{{ $t('notifications.overview.headers.account_groups') }}

    Date: Thu, 12 Sep 2024 15:37:31 +0200 Subject: [PATCH 2/7] chore(git-blame-ignore): add `styling` commit --- .git-blame-ignore-revs | 2 ++ frontend/.vscode/settings.json | 1 + 2 files changed, 3 insertions(+) diff --git a/.git-blame-ignore-revs b/.git-blame-ignore-revs index 7e6614089..23196270b 100644 --- a/.git-blame-ignore-revs +++ b/.git-blame-ignore-revs @@ -4,6 +4,8 @@ # in order to work execute once: # git config blame.ignoreRevsFile .git-blame-ignore-revs +#chore(eslint): add `natural sorting` for `json` files +f3da99c5c685eae1914aad8513d3b4b2f1cdcaa2 # style(eslint): add `typescript delimiter` rule d6b42edb3f687cad3082a9044bcb71fc39a46176 # style(eslint): apply `max-len` rule diff --git a/frontend/.vscode/settings.json b/frontend/.vscode/settings.json index 0a9948f53..05c5c7c04 100644 --- a/frontend/.vscode/settings.json +++ b/frontend/.vscode/settings.json @@ -15,6 +15,7 @@ "eslint", "feature-flags", "git", + "git-blame-ignore", "i18n", "mainHeader", "notifications", From b0c5ecf88da91e3dd3ceb81065e89fc0b5111674 Mon Sep 17 00:00:00 2001 From: marcel-bitfly <174338434+marcel-bitfly@users.noreply.github.com> Date: Thu, 26 Sep 2024 15:20:44 +0200 Subject: [PATCH 3/7] refactor(BcButton): fix `disabled state` Due to an update of VuePrime the `css specifity` must be higher. --- frontend/.vscode/settings.json | 1 + frontend/components/bc/BcButton.vue | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/frontend/.vscode/settings.json b/frontend/.vscode/settings.json index 05c5c7c04..b86e87779 100644 --- a/frontend/.vscode/settings.json +++ b/frontend/.vscode/settings.json @@ -1,5 +1,6 @@ { "conventionalCommits.scopes": [ + "BcButton", "BcLink", "BcTablePager", "DashboardChartSummaryChartFilter", diff --git a/frontend/components/bc/BcButton.vue b/frontend/components/bc/BcButton.vue index 1e159f2f6..829b6e367 100644 --- a/frontend/components/bc/BcButton.vue +++ b/frontend/components/bc/BcButton.vue @@ -39,7 +39,7 @@ const shouldAppearDisabled = computed( diff --git a/frontend/components/bc/BcListSection.vue b/frontend/components/bc/BcListSection.vue new file mode 100644 index 000000000..3360f8a75 --- /dev/null +++ b/frontend/components/bc/BcListSection.vue @@ -0,0 +1,26 @@ + + + + + diff --git a/frontend/components/bc/BcScreenreaderOnly.vue b/frontend/components/bc/BcScreenreaderOnly.vue new file mode 100644 index 000000000..3364a23ab --- /dev/null +++ b/frontend/components/bc/BcScreenreaderOnly.vue @@ -0,0 +1,35 @@ + + + + + diff --git a/frontend/components/bc/BcSlider.vue b/frontend/components/bc/BcSlider.vue new file mode 100644 index 000000000..b3dcaf9c0 --- /dev/null +++ b/frontend/components/bc/BcSlider.vue @@ -0,0 +1,91 @@ + + + + + diff --git a/frontend/components/bc/BcText.vue b/frontend/components/bc/BcText.vue new file mode 100644 index 000000000..b49083f53 --- /dev/null +++ b/frontend/components/bc/BcText.vue @@ -0,0 +1,37 @@ + + + + + diff --git a/frontend/components/bc/BcTextNumber.vue b/frontend/components/bc/BcTextNumber.vue new file mode 100644 index 000000000..d73e3a7b1 --- /dev/null +++ b/frontend/components/bc/BcTextNumber.vue @@ -0,0 +1,37 @@ + + + + + diff --git a/frontend/components/bc/premium/BcPremiumGem.vue b/frontend/components/bc/premium/BcPremiumGem.vue index 45152a6f2..be15b3534 100644 --- a/frontend/components/bc/premium/BcPremiumGem.vue +++ b/frontend/components/bc/premium/BcPremiumGem.vue @@ -1,16 +1,28 @@