You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We can see the end of the loop is being set to the size of the sample. But it’s expecting an index (like the loop start above it). So the loop region actually hangs one sample off the end of the wav.
This causes some clients to discard all loop information in the file, and causes others to play random memory for that extra sample.
As a fix, an index should be used instead of a size. In practice, this is just a matter of decrementing the size by one.
The text was updated successfully, but these errors were encountered:
The loop end point of the smpl chunk suffers from an off-by-one error.
https://github.com/gocha/split700/blob/v2.0/src/WavWriter.cpp#L121
We can see the end of the loop is being set to the size of the sample. But it’s expecting an index (like the loop start above it). So the loop region actually hangs one sample off the end of the wav.
This causes some clients to discard all loop information in the file, and causes others to play random memory for that extra sample.
As a fix, an index should be used instead of a size. In practice, this is just a matter of decrementing the size by one.
The text was updated successfully, but these errors were encountered: