Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only error about missing fonts if text is actually drawn #160

Open
eaburns opened this issue Mar 17, 2015 · 2 comments
Open

Only error about missing fonts if text is actually drawn #160

eaburns opened this issue Mar 17, 2015 · 2 comments

Comments

@eaburns
Copy link
Member

eaburns commented Mar 17, 2015

Original issue 132 created by eaburns on 2013-07-08T11:26:19.000Z:

Currently, plot.New returns an error if it cannot find the default font. There are two concerns here: 1) if the default font will remain unexported then this might as well be a panic, and 2) we should support drawing plots that do not contain any text if the fonts aren't actually installed.

My plan is: export the defaultFont variable, leave the error return on plot.New, and change plot and vg so that, if the fonts aren't installed, they only error if/when text is actually drawn.

@eaburns
Copy link
Member Author

eaburns commented Mar 17, 2015

Comment #1 originally posted by eaburns on 2014-12-08T11:38:06.000Z:

Yes, please export the defaultFont variable. That would make customizing text style much easier.

@eaburns
Copy link
Member Author

eaburns commented Mar 17, 2015

Comment #2 originally posted by eaburns on 2014-12-20T14:43:04.000Z:

See issue 147 for exporting defaultFont.

@eaburns eaburns removed their assignment Mar 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant