Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a better way to handle syncing custom values applied to product options #118

Open
good-idea opened this issue Aug 14, 2020 · 0 comments

Comments

@good-idea
Copy link
Owner

Product option info returned from Shopify only includes the values as strings, i.e.:

{
  name: 'Color',
  id: '....shopifyId',
  values: ['Green', 'Blue', 'Yello']
}

sync-utils will then create a new entry for each of these values. But, if these values change in Shopify, (i.e. Yello is changed to Yellow), there is no way of knowing that this is the same option as before, but with a new name. (The sanity key for each of these entries is generated from the value itself)

So, for now:

  • The old entry for Yello will stay in sanity and not be removed
  • Users will need to copy values from Yello to Yellow

What would be nice:

  • Flag outdated entries (Yello) as such
  • Add some UI to the "Value" field in this entry, notifying the user that it's not linked to any option, and offering a button/menu that allows them to update the value by selecting a valid one (Yellow)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant