From a69233948cf850c99d191bb88e51b83d7026e9a5 Mon Sep 17 00:00:00 2001 From: Emily Ploszaj Date: Thu, 6 Jun 2024 13:11:27 -0500 Subject: [PATCH] Adjust failure wording --- .github/workflows/check-api-changes.yml | 6 +----- .../java/com/google/gradle/tasks/WarnVersionBumpTask.kt | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/workflows/check-api-changes.yml b/.github/workflows/check-api-changes.yml index e0badd0b..919f0c16 100644 --- a/.github/workflows/check-api-changes.yml +++ b/.github/workflows/check-api-changes.yml @@ -3,7 +3,7 @@ name: Check API Changes on: pull_request jobs: - check-format: + check-api-changes: runs-on: ubuntu-latest steps: - name: Checkout branch @@ -17,7 +17,3 @@ jobs: - name: Run API versioning check run: | if ! test -d .changes || ! git diff --quiet HEAD^..HEAD .changes ; then ./gradlew warnVersionBump ; else exit 0 ; fi - - name : Log errors - if: failure() - run: | - echo "PR contains a Major or Minor API bump without an associated changelog entry. Either generate a changelog entry for the change or revert the API changes." diff --git a/plugins/src/main/java/com/google/gradle/tasks/WarnVersionBumpTask.kt b/plugins/src/main/java/com/google/gradle/tasks/WarnVersionBumpTask.kt index ec9c2c14..c1880d26 100644 --- a/plugins/src/main/java/com/google/gradle/tasks/WarnVersionBumpTask.kt +++ b/plugins/src/main/java/com/google/gradle/tasks/WarnVersionBumpTask.kt @@ -45,7 +45,7 @@ abstract class WarnVersionBumpTask : DefaultTask() { val diff = LinesChanged.fromFile(changesFile.asFile.get()) if (diff.bump == MAJOR || diff.bump == MINOR) { - throw TaskExecutionException(this, Exception("Changes are ${diff.bump}, higher than PATCH")) + throw TaskExecutionException(this, Exception("Changes are ${diff.bump}, higher than PATCH. If this is intended, add a changelog entry. Otherwise, revert the changes.")) } } }