Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java SDK compatibiliy #325

Closed
sv99 opened this issue Apr 12, 2023 · 1 comment
Closed

Java SDK compatibiliy #325

sv99 opened this issue Apr 12, 2023 · 1 comment

Comments

@sv99
Copy link

sv99 commented Apr 12, 2023

Java SDK 1.8

Build error

  1. src/test/java/com/android/tools/build/bundletool/commands/BuildSdkApksForAppCommandTest.java:376: error: cannot find symbol InputStream.readAllBytes()
  2. src/test/java/com/android/tools/build/bundletool/commands/BuildSdkApksForAppCommandTest.java:130: error: cannot find symbol Files.writeString(Path,String)
  3. src/test/java/com/android/tools/build/bundletool/commands/BuildApksCommandTest.java:1477: error: cannot find symbol Files.writeString(Path,String)

OpenJDK 17

Build OK

Test Fail

resourcesLocaleConversions_oldLanguageCodes in the src/test/java/com/android/tools/build/bundletool/model/utils/ResourcesUtilsTest.java

This backward compatibility for old ISO-639 language. Since Java SE 17, this is no longer the case.

OpenJDK 19, 20

Build OK

Test OK after upgrade gradle to 8.1 with PR 328

@ymakhno
Copy link

ymakhno commented Aug 9, 2023

We support bundletool builds on JDK 11. In runtime any JRE 8+ can be used.

We do not have plans to support builds on any other JDKs at the moment. Eventually we will migrate from JDK 11 to JDK 21.

@ymakhno ymakhno closed this as completed Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants