Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Emery (with another name) #6124

Open
7 of 9 tasks
davelab6 opened this issue Mar 28, 2023 · 9 comments · May be fixed by #8740
Open
7 of 9 tasks

Add Emery (with another name) #6124

davelab6 opened this issue Mar 28, 2023 · 9 comments · May be fixed by #8740
Assignees
Labels
-- fontforge/fontlab/fontcreator sources that are not UFO/Glyphs natively -- Requires Axis Registration Variable axes are not yet registered I New Font II Accepted Non-commissioned projects that are accepted for onboarding II Custom axes Contains unregistered MS axis (even if registered by GF) P3
Milestone

Comments

@davelab6
Copy link
Member

davelab6 commented Mar 28, 2023

Font Project Git Repo URL:

https://github.com/googlefonts/emery-3

Super short description of the Font Family:

Christian Mosmüller emailed fonts@ with,

I am writing to submit my font, Emery³, for consideration to be included in the Google Fonts library. Emery³ is a striking, variable Display Font specifically designed for animation on the web, featuring three variable axes.

Feel free to also use my website to check out the font: https://cmosmueller.ndu.schulwebspace.at/varWeb/

As the sole original author of Emery³, I would like to declare that I hold all the necessary rights to license the font under the Open Font License (OFL).

Enclosed in this email is the source file for Emery³ as well as a variable TTF file, which is available for you to take care of everything else. I believe that Emery³ would be a great addition to the already impressive collection of fonts available on the Google Fonts website.

Thank you for considering my submission. I look forward to hearing back from you soon.

I created a Github repo for it, above.

Requirements:

I understand that Google Fonts will publish only fonts that matches its requirements, and I can confirm the project meets them (by ticking the cases, or putting x between the square brackets in text mode):

  • The entire font project is licensed under the OFL
  • There is no "Reserved Font Name" mention in the OFL license
  • Family name is unique according to namecheck.fontdata.com I asked Christian to propose a new name, as a simple Google search shows existing fonts with the name "Emery"
  • The font supports at least GF Latin Core glyphset (I didn't check this yet.)
  • The repository respect the upstream repo structure
  • The source files are available in the repository
  • I read, agree and comply with the full contributing requirements
  • I am the author of the font or the author agreed to this submission
  • I will maintain the repository He's asked to do so :)

Image:

image1

Screenshot 2023-03-28 at 11 05 15 AM

Screenshot 2023-03-28 at 11 05 08 AM

@davelab6 davelab6 added - Ready for Review -- Requires Axis Registration Variable axes are not yet registered I New Font II Accepted Non-commissioned projects that are accepted for onboarding II Custom axes Contains unregistered MS axis (even if registered by GF) labels Mar 28, 2023
@davelab6 davelab6 added this to the 2023 Q2 milestone Mar 28, 2023
@RosaWagner RosaWagner modified the milestones: 2023 Q2, 2023 Q3 Apr 20, 2023
@davelab6
Copy link
Member Author

I expect the "length" axis would be onboarded as YTRA, since it effects the Y transparency overall. This will need review of the line-height behaviour with our v metrics policy. @vv-monsalve will investigate that as part of the Playpen onboarding and its "extenders" axis.

@chrissimpkins chrissimpkins modified the milestones: 2023 Q3, 2023 Q4 Oct 3, 2023
@RosaWagner RosaWagner removed the P1 label Oct 5, 2023
@chrissimpkins chrissimpkins modified the milestones: 2023 Q4, Icebox Jan 2, 2024
@chrissimpkins chrissimpkins modified the milestones: Icebox, Backlog Jan 10, 2024
@chrissimpkins chrissimpkins modified the milestones: Backlog, 2024 Q2 Apr 2, 2024
@vv-monsalve vv-monsalve added the -- fontforge/fontlab/fontcreator sources that are not UFO/Glyphs natively label Apr 11, 2024
@davelab6 davelab6 assigned yanone and unassigned vv-monsalve Apr 16, 2024
@davelab6
Copy link
Member Author

As a large designSpace VF project, I love Emery, and would like to see it onboarded soon, but @vv-monsalve is focued on Playwrite in Q2... and since it has VFB sources I'm reassigning from @vv-monsalve to @yanone for an initial review in Q2 :)

@yanone
Copy link
Collaborator

yanone commented May 10, 2024

I don't see how the vertical extension axis makes sense. I tried out the font in a browser as well as in Indesign, and neither environments respect the change in vertical metrics that comes as part of the vertically extended masters, see screenshots (with length axis fully extended).

If indeed only a single-line typesetting is intended here it might work, but then again you have the issue that the default weight's v-metrics are applied, so unless the vertical extension is planned-for in the design document, a change in axis parameters might cause the text to crash into visual objects above it.

One possible solution is to apply the vertically extended v-metrics for all masters, leaving an awful lot of white space for the default master, which in turn is very unusual for a font and might leave users confused.

The GF Guide technically allows v-metrics of over 120% of UPM, but I don't see how we can create or offer a meaningful user-experience for such weird metrics. The sum of v-metrics is 3,120 for the extended lengths, so 312% of UPM.

Edit: An automatic adjustment of line-height could be implemented programmatically in a browser alongside a change in axis value, but that doesn't come as part of the default CSS font usage, and static environments like DTP apps won't be supported.

Browser:
Image

Indesign:
Image

@yanone yanone moved this from Todo to In Progress in Google Fonts May 10, 2024
@yanone
Copy link
Collaborator

yanone commented May 10, 2024

Update: I wasn't aware of the proper production process for the YTRA axis and checked the shipped .ttf file rather than producing new fonts using our toolchain.

I will repeat the process again next week and report back.

@yanone yanone moved this from In Progress to Todo in Google Fonts May 15, 2024
@yanone yanone moved this from Todo to In Progress in Google Fonts May 15, 2024
@yanone
Copy link
Collaborator

yanone commented May 23, 2024

Sources are unusable as-is with regards to mostly anchor compatibility, double above/below use of components. @davelab6 says to notify author to update sources in line with GF guide (need to cross-check some details). Waiting for contact details, as the website link at the top won't yield any

@yanone
Copy link
Collaborator

yanone commented Jun 13, 2024

Emailed author about how to approach improvements. Since assignment by Dave is "initial review", I consider this done for now and we'll see whether the author returns with updated sources.

@chrissimpkins
Copy link
Collaborator

Will leave this with Yanone and pick up work on it in September.

@yanone
Copy link
Collaborator

yanone commented Nov 22, 2024

The font is in proof-of-concept-complete stage, meaning that the YEXT vertical metric interpolation works. Meanwhile, the YEXT PR over at the axisregistry has been merged in preparation for Emery Cubic.

I recently fixed loads of outline interpolation issues after the conversion from Fontlab sources, and asked the author on October 15th by email to add a few missing glyphs as well correct the metrics of the tabular figures (or alternatively delete them).

If he doesn't respond in a while, I can also make the necessary changes myself which shouldn't take more than a few hours, so either way I expect that I can hand in the fonts at the end of Q4.

@yanone
Copy link
Collaborator

yanone commented Nov 28, 2024

Fixed remaining outline and glyph issues myself after author responded he only work on Windows (= no Glyphs.app).

Now waiting for a description text from author for onboarding.

yanone added a commit that referenced this issue Dec 13, 2024
@yanone yanone linked a pull request Dec 13, 2024 that will close this issue
@yanone yanone moved this from In Progress to PR GF in Google Fonts Dec 13, 2024
@yanone yanone moved this from PR GF to In Progress in Google Fonts Dec 20, 2024
yanone added a commit that referenced this issue Dec 20, 2024
@chrissimpkins chrissimpkins modified the milestones: 2024 Q4, 2025 Q1 Jan 7, 2025
@yanone yanone linked a pull request Jan 9, 2025 that will close this issue
yanone added a commit that referenced this issue Jan 9, 2025
@yanone yanone moved this from In Progress to Blocked in Google Fonts Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-- fontforge/fontlab/fontcreator sources that are not UFO/Glyphs natively -- Requires Axis Registration Variable axes are not yet registered I New Font II Accepted Non-commissioned projects that are accepted for onboarding II Custom axes Contains unregistered MS axis (even if registered by GF) P3
Projects
Status: Blocked
Development

Successfully merging a pull request may close this issue.

5 participants