-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve guava-android
Animal Sniffer compatibility testing for Java 8+ APIs
#7197
Comments
Another part of the picture is [edit: Currently, we're inconsistent about whether to use |
This almost became non-theoretical: As I learned in the course of investigating open-toast/gummy-bears#64, |
Putting the annotations in both branches might also reduce the number of differences in the class files generated by the two flavors (especially if we also remove the |
The introduction of different annotations would also be an opportune time to fix the https://errorprone.info/bugpattern/IdentifierName violation of the current annotations. |
We might also be able to arrange for |
As of 33.2.0 (and even slightly earlier for package-private and
guava-testlib
APIs), we have APIs in our Android flavor that require library desugaring. For them, we disable Animal Sniffer. We could do better by having multiple Animal Sniffer runs:Then we'd want to use 2 slightly different sets of annotations to disable Animal Sniffer:
This is not a great description of what I'm going for, but I wanted to get down some rough notes after already touching on this in the linked TODO and in the release notes.
The text was updated successfully, but these errors were encountered: