Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate offline recommendation Task loops indefinitely #921

Open
mitar06 opened this issue Jan 8, 2025 · 0 comments
Open

Generate offline recommendation Task loops indefinitely #921

mitar06 opened this issue Jan 8, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@mitar06
Copy link

mitar06 commented Jan 8, 2025

Gorse version
zhenghaoz/gorse-in-one:latest

Describe the bug
I am trying Gorse out with the provided github interactions dataset, everything runs fine on docker but I have noticed that the 'Generate offline recommendation' task keeps restarting indefinitely. I do understand that check_recommend_period and refresh_recommend_period variables dictate if offline recommendations will be recalculated (https://gorse.io/docs/master/concepts/how-it-works.html#worker-offline-recommendation) .
Currently these variables are set as:

  • check_recommend_period = "1m"
  • refresh_recommend_period = "24h"

I have confirmed that the Generate offline recommendation Task loops even if I don't add any additional users, items or feedbacks.

To Reproduce

  • Ran docker compose locally
  • successfully imported the demo data into mysql container
  • Restarted all containers
  • Let all tasks complete successfully on the "Tasks" page

Expected behavior
Offline recommendations not being calculated over and over again if there weren't any new users, items or feedbacks added to the system .

Additional context
Maybe an issue related/similar to this one ( #789 )
I am attaching my docker logs to the issue in case those can help.
dockerLogGorse.txt
dockerLogRedis.txt
dockerLogMySql.txt

Here is the config I am currently using, along with the config.toml file:
config.toml.txt
docker-compose.yaml.txt

Please let me know if this is the expected behavior or if something needs to be adjusted on my end, my team is looking to use Gorse more on the daily to generate predictions on labeled data, and our main concern is that calculating offline recommendations every minute will use too much of our hardware resources as the underlaying data grows in size.

@mitar06 mitar06 added the bug Something isn't working label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant