Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Rav Request #269

Open
gusinacio opened this issue Aug 1, 2024 · 1 comment
Open

Refactor Rav Request #269

gusinacio opened this issue Aug 1, 2024 · 1 comment
Labels
p3 Low priority pgk:tap-agent repo:indexer-rs size:x-large Very large type:refactor Changes not visible to users

Comments

@gusinacio
Copy link
Member

Problem statement
Currently, the Rav Request system is not stable, any failure causes problems in the whole system.

The refactor between tap-core and tap-agent seems necessary to improve reliability, readability and maintainability.

@calinah
Copy link

calinah commented Sep 19, 2024

this error is related

2024-09-19T20:15:10.486623Z DEBUG indexer_tap_agent::agent::sender_account: Total fee greater than the trigger value. Triggering RAV request, total_fee: 3044480420616669893, trigger_value: 2500000000000000000
    at tap-agent/src/agent/sender_account.rs:578
    in ractor::actor::Actor with id: "0.1", name: "0xDDE4cfFd3D9052A9cb618fC05a1Cd02be1f2F467"

  2024-09-19T20:15:10.486641Z ERROR indexer_tap_agent::agent::sender_allocation: Can't trigger rav request until Instant { tv_sec: 1262165, tv_nsec: 167912880 } (backoff)
    at tap-agent/src/agent/sender_allocation.rs:264
    in ractor::actor::Actor with id: "0.35", name: "0xDDE4cfFd3D9052A9cb618fC05a1Cd02be1f2F467:0xdE477aFB87B72E6CA7447d6B35254771088521Ce"

It seems the error indicates that too many RAV requestes are being requested at once and there's an enforced backoff to slow things down

@gusinacio gusinacio added size:x-large Very large p3 Low priority type:refactor Changes not visible to users labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3 Low priority pgk:tap-agent repo:indexer-rs size:x-large Very large type:refactor Changes not visible to users
Projects
None yet
Development

No branches or pull requests

2 participants