Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a scale argument to plot #96

Open
erikcs opened this issue Dec 18, 2024 · 0 comments
Open

Add a scale argument to plot #96

erikcs opened this issue Dec 18, 2024 · 0 comments
Labels
feature New feature or request

Comments

@erikcs
Copy link
Member

erikcs commented Dec 18, 2024

It is useful to relate the policy values in plots to problem specific aggregates, for example, in Figure 5 here we show estimates of intervening on n~2500 units. It's possible to achieve this by just scaling your evaluation scores and costs when calling into maq, but a more direct interface would be nicer.

A natural way to do so would be to delegate this choice to plot, e.g,

plot(qini, scale = 2500, ...)

Would plot the policy values and costs multiplied by 2500.

If you want to read off policy values using average_gain you'd have to do the scaling yourself:

2500 * average_gain(qini, spend = something)

(just tagging @swager in case you have any other opinions on this).

@erikcs erikcs added the feature New feature or request label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant