Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual improvements to reporting by various scripts #32

Open
malachig opened this issue Jan 30, 2025 · 1 comment
Open

Visual improvements to reporting by various scripts #32

malachig opened this issue Jan 30, 2025 · 1 comment

Comments

@malachig
Copy link
Member

  • For get_neoantigen_qc.py and get_FDA_thresholds.py . Avoid really long decimals for human readability. e.g. duplication rates look like this. "12.929599656902 (%)". We currently manually change these to look like "12.9%". Throughout the report, in most places we could use 1-4 decimal points. Looking at an example one can see what look reasonable.

  • In these same results, for very long integers, use commas in report. e.g. "283794038" -> "283,794,038"
    For hla_comparison.py. Make sure that whenever there is a pair of HLA alleles for the same gene ... e.g. HLA_A-1, HLA_A-2 where the values are "A02:01 A01:01". Make sure these pairs are always listed alphabetically. This helps to see across the predictions if they are identical or not.

  • For generate_reviews_files.py currently fails to run if the .xlsx input file has the extra header row. This line currently says "Exported data". pVACview generates this on export of results.

  • For color_peptides51mer.py thresholds are used to decide if a class I peptide is colored red, or a class II peptide bolded, and whether these alleles listed in "RESTRICTING HLA ALLELE" column. We would like to be able to configure those, but they are currently hard coded?

@evelyn-schmidt
Copy link
Collaborator

Human readable decimals fixed in PR31! Docker version6!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants