- Author(s): [email protected]
- Approver: [email protected]
- Status: Approved
- Implemented in: Core
- Last updated: 1/11/2022
- Discussion at: https://groups.google.com/g/grpc-io/c/nJYz60XHLuo
Remove slice interning related APIs.
gRPC Core used to rely on slice interning to improve metadata handling performance. Recent advancements in the metadata system design have obviated the need for this, and so it's time to remove the API complexity incurred by this feature.
None.
Remove the following APIs:
- grpc_slice_intern
- grpc_slice_default_hash_impl
- grpc_slice_default_eq_impl
- grpc_slice_hash
The first removes the ability to create an interned slice. Because interned slices had opinions about hashing and equality (since they could optimize those operations) we introduced hashing and equality hooks when interning was introduced. These hooks are no longer required, so we'll remove the gRPC opinion on how slices should be hashed - wrapped languages are of course free to choose their own hash function for slice data.
We don't need this anymore.
This is implemented in grpc/grpc#28363.