Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

equilibrium: fix variable name clash in reader for some systems #12

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

aaronkho
Copy link
Collaborator

@aaronkho aaronkho commented Jan 8, 2025

The number variable name escapes inline scope in some combinations of Python version and device architecture, which then clashes with the namespace of the number() function. This change fixes any potential clash by renaming the variable.

@aaronkho aaronkho requested a review from gsnoep January 8, 2025 22:45
@aaronkho aaronkho marked this pull request as ready for review January 8, 2025 22:46
@aaronkho
Copy link
Collaborator Author

aaronkho commented Jan 8, 2025

Bug found by Pablo Rodriguez-Fernandez.

@gsnoep
Copy link
Owner

gsnoep commented Jan 9, 2025

This also solves #11! Thanks for figuring this out @pabloprf and @aaronkho!

@gsnoep gsnoep merged commit 52cfc0e into main Jan 9, 2025
@gsnoep gsnoep deleted the reader_bugfix branch January 9, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants