From 022b2c740c61687005d00967656f7f16f2067880 Mon Sep 17 00:00:00 2001 From: Jon Date: Sat, 6 Jan 2024 10:59:16 +0000 Subject: [PATCH] Notes against party stats --- GWToolboxdll/Windows/PartyStatisticsWindow.cpp | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/GWToolboxdll/Windows/PartyStatisticsWindow.cpp b/GWToolboxdll/Windows/PartyStatisticsWindow.cpp index 8c3f5f86e..02e265999 100644 --- a/GWToolboxdll/Windows/PartyStatisticsWindow.cpp +++ b/GWToolboxdll/Windows/PartyStatisticsWindow.cpp @@ -140,9 +140,18 @@ namespace { }); return found != party_members.end() ? *found : nullptr; } - PartyMember* GetPartyMemberByEncName(const wchar_t* enc_name) { + /* + @Cleanup: + - What happens when 3 players each bring the same hero ? "Ebon Vanguard Mesmer" x 2 + - GW sometimes sends the enc_name packet after the NPC is created; would this affect henchmen? + - Players can have names that match heros or henchmen in some edge cases + - Obfuscator could be a problem + + Instead maybe hook into the PartyPlayerAdd / PartyAllyAdd / PartyHeroAdd packets, then identify by player owner / hero id instead of just using name + */ + if (pending_party_members) return nullptr; const auto found = std::ranges::find_if(party_members, [enc_name](const auto party_member) {