Skip to content
This repository has been archived by the owner on Aug 5, 2019. It is now read-only.

Update to Bootstrap 3.0.0 #448

Open
peterfortuin opened this issue Oct 29, 2013 · 14 comments
Open

Update to Bootstrap 3.0.0 #448

peterfortuin opened this issue Oct 29, 2013 · 14 comments

Comments

@peterfortuin
Copy link

Is it possible to update the boostrap css files to 3.0.0?
In my project I want to use the 3.0.0 bootstrap, but the version from gwt-bootstrap is automatically included.

@caarlos0
Copy link
Contributor

without a little ammount of work, no. We have tons of classes that will need to be rewriten/fixed for this to work.

@peterfortuin
Copy link
Author

Ok. Clear answer.
Is there some way to include into your module to access the classes, but don't automatically include the css file?

@caarlos0
Copy link
Contributor

I believe not, sorry... Maybe @soundTricker knows some way to do that...

I think that if you include both BS 2 and 3 files everything will be messed up..

@peterfortuin
Copy link
Author

Yes, including both BS 2 and 3 gives problems. But only including BS 3 is good enough for me. Didn't see any problems with that (for what I use it for).
Is BS 3 on the long term roadmap for this project?

@caarlos0
Copy link
Contributor

Oh, sorry, didn't understand you first time.

So, using only BS3 CSS file with GWT-Bootstrap will not work, since almost all css-classes changed.

About the roadmap, a PR is always well accepted. Meanwhile, maybe @reinert have some insights.

Cheers.

@reinert
Copy link
Contributor

reinert commented Oct 29, 2013

Yes, it is.

D. Reinert

On Tue, Oct 29, 2013 at 9:35 AM, peerke [email protected] wrote:

Yes, including both BS 2 and 3 gives problems. But only including BS 3 is
good enough for me. Didn't see any problems with that (for what I use it
for).
Is BS 3 on the long term roadmap for this project?


Reply to this email directly or view it on GitHubhttps://github.com//issues/448#issuecomment-27298913
.

@jgodi
Copy link
Contributor

jgodi commented Nov 13, 2013

I am sure there are plenty of people willing to help if you wanted to start a branch for Bootstrap v3 integration and then get some people and split the work?

I know I would personally devote some time in achieving this goal.

@caarlos0
Copy link
Contributor

Okay, since lots of people seems to be willing to contribute, I just branched the bs-3.

There have been a lot of time since I last used GWT for work, so, I'm a little rusty, but, if I got sometime, I'll try to help too, or at least support who wants to work in it.

Cheers!

@peterfortuin
Copy link
Author

I'm also willing to contribute, but I have no idea where to start.

@caarlos0
Copy link
Contributor

I think we should:

  • Replace the needed assets
  • Fix the constants with the classes that changed
  • Fix components if needed
  • Maybe write a new showcase

Anyone have more ideas?

@jgodi
Copy link
Contributor

jgodi commented Nov 14, 2013

A lot has changed in BS3, so the best course of action would be a new showcase I think. Many of the core functionality is still there and will work. Just many of the layouts (i.e FluidContainer/FluidRow and Column sizes are all totally different). I will begin work on it tonight/over the weekend. Thanks!

Maybe we should create a document somewhere and split up the features/tasks, so that we can accomplish this and not step on each others toes.

@reinert
Copy link
Contributor

reinert commented Nov 22, 2013

I'm interested on it too!

We DO need a doc for guidance.

First, we sould list architectural features from bs3, (those reused in
almost everywhere)

Then we should work on components based on css only.

Last, work on javascript based features.

I think this is the best way to go, since js gives us more complexity to
deal.

Em quinta-feira, 14 de novembro de 2013, jgodi escreveu:

A lot has changed in BS3, so the best course of action would be a new
showcase I think. Many of the core functionality is still there and will
work. Just many of the layouts (i.e FluidContainer/FluidRow and Column
sizes are all totally different). I will begin work on it tonight/over the
weekend. Thanks!

Maybe we should create a document somewhere and split up the
features/tasks, so that we can accomplish this and not step on each others
toes.


Reply to this email directly or view it on GitHubhttps://github.com//issues/448#issuecomment-28484828
.

D. Reinert

@caarlos0
Copy link
Contributor

I agree with both @reinert and @jgodi...

Can someone start doing this list?

@svenjacobs
Copy link
Contributor

An alternative would be to use GwtBootstrap3. We're not feature complete yet but most of Bootstrap v3 components are supported.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants