Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: Add Accessibility checker to default CKEditor button toolbar #43

Open
nadavkav opened this issue Nov 30, 2017 · 4 comments

Comments

@nadavkav
Copy link

Please see if you can add Accessibility checker (button) to CKEditor
https://ckeditor.com/ckeditor-4/accessibility-checker/

Generate a new version with "Accessibility checker" and have a hosting environment (Moodle/WP/Drupal/...) system setting to show/hide this new button.

@nadavkav nadavkav changed the title Add Accessibility checker to default CKEditor button toolbar New Feature: Add Accessibility checker to default CKEditor button toolbar Nov 30, 2017
@fnoks
Copy link
Contributor

fnoks commented Dec 7, 2017

The default ckeditor setup for the H5P content types is limited, i.e. there are few buttons in the toolbar. So I am wondering what kind of accessibility problems it could find? The only thing I would imagine it could find is bad contrast for text with a background color set, but it might be more? Do you know what it typically could find in the H5P context?

@nadavkav
Copy link
Author

They are using the https://github.com/quailjs libraries which are based on WCAG 2 guidelines. (actually, the original quailjs project is no longer maintained, and they recommend a switch to aXe)

I am more concern about what users can copy and paste into H5P components, and not what they can break when using its limited set of buttons. (I have unpleasant "have to clean" experience with users pasting Word (MS) content into CKEditor, over the years)

I am thinking about an option for the system administrator, to be able to decide if this new accessibility checker button is available or not, like what we did with the "RTL/LTR" BIDI buttons, here:
iucc/h5p-moodle-plugin@c2b0ae5
What do you think?

@falcon-git
Copy link
Member

It could be something. Do note that H5P will typically remove any html tags that are pasted in if they can't be added via the limited ckeditor options allowed for the field

@nadavkav
Copy link
Author

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants