Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable upload of content types when not allowed #87

Closed
t-schroeder opened this issue Jul 19, 2019 · 2 comments
Closed

Disable upload of content types when not allowed #87

t-schroeder opened this issue Jul 19, 2019 · 2 comments

Comments

@t-schroeder
Copy link

When someone doesn't have the "mod/hvp:updatelibraries" capability wouldn't it make sense to disable upload of own Content types/libraries? As I understand it each Content type is also a library. So if you can't install/update libraries is there even any Content type you can upload? If not I would suggest disabling the upload dialog for .h5p files in that case.

I already mentioned in #86 that the error message you get when missing this capability and trying to upload a new Content type is not great. This issue describes basically the same problem. Namely that it's not clear to the user what he can actually upload in this scenario.

@otacke
Copy link
Contributor

otacke commented Jul 19, 2019

@t-schroeder A content file is merely a zip archive that contains all libraries that the content type uses + media content used + the parameters given. Those libraries inside are not installed every time someone uploads content, but only if the libraries in that particular version are not present on the system and the user has the capability to upload libraries.

Not preventing file uploads if someone doesn't have the updatelibraries capabilities makes sense because otherwise users could not restore content that they may have made a backup of and they couldn't share content with others on other platforms. With the rules as they are today, users can do this while they can't install newer library versions that come with newer content type versions.

@t-schroeder
Copy link
Author

@otacke thanks for clarifying that. I'm closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants