-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable images in question content #11
Comments
In an H5P context, the WYSIWYG is mostly intended for textual content and not as much for structure and visuals. Allowing images in the text would make the content more unpredictable and it will become more difficult to make changes to the content types without breaking anything. Ideally, the images that are needed should be added as separate fields. Also, UX wise, I think it's preferable to create familiar patterns for the users. I don't think this is something that will be including per default in H5P, but you are more than welcome to create 3rd party plugins that modifies the semantics and add support for it. |
It seems to me that content creators (and their QA team) should be responsible for checking out the outcome of inserting images into content on different devices. making the UI more complicated by adding new input fields for images and their properties will render the editing UI too complex. Anyways, I talked about this with @leac (offline) and I still think she and the pedagogical content creators are right. So I guess we will fork it, as we need this feature on many content contextes. |
You don't need to fork it to add this. You may use the corresponding hooks to alter the semantics without forking, see this example for Drupal for instance: https://h5p.org/adding-text-editor-buttons |
Thank you @falcon-git for the link. I read it, but did understand how to implement it in Moodle. I probably need to dive deeper into the H5P code. 😄 |
These hooks are not yet available in Moodle. They will be added in a later release. |
Are you guys referring to these https://tracker.moodle.org/browse/MDL-44078 hooks? |
@nadavkav: No, we are talking about this one: h5p/moodle-mod_hvp#26 |
wow! I was not aware of this. On 9 Aug 2016 11:44, "Pål Jørgensen" [email protected] wrote: Are you guys referring to these https://tracker.moodle.org/browse/MDL-44078 @nadavkav https://github.com/nadavkav: No, we are talking about this one: — Reply to this email directly, view it on GitHub |
We would like to be able to add images to any component (semantic) of the question (question, answers, feedback, ...):

In order to do that, so far we've been altering the multichoice package: In
semantics.json
we add theimg
tag to the list of tags. For example:Please see if you can add this feature to the core.
(This request is part a bigger discussion already started on issue )
The text was updated successfully, but these errors were encountered: