Auth page #53
Auth page #53
Conversation
…tion requests table
|
lighthouse workflow will fail since we do not have a way of it connecting to a database when it runs the build yet. But that should be a separate issue |
|
Also profile and account settings page will be its own issue. And forgot password requests will be its own issue |
|
Now that this is done the backend is fully working and up and running. And authentication with and without Feide should work. If you want to test you can login with the Frank Sinatra account which is currently being seeded to the database. |
michaelbrusegard
requested review from
HaakonWiland
and removed request for
ZeroWave022
|
|
||
| import { EyeIcon, EyeOffIcon } from 'lucide-react'; | ||
| import { useTranslations } from 'next-intl'; | ||
| import * as React from 'react'; |
There was a problem hiding this comment.
Should import only useState instead of react
| @@ -0,0 +1,11 @@ | |||
| const skillIdentifiers = [ | |||
| 'printing', | |||
| 'souldering', | |||
| }, | ||
| '/auth/success': { | ||
| en: '/auth/success', | ||
| no: '/autentisering/success', |
There was a problem hiding this comment.
skal den her være på engelsk?
| import { type InsertUser, users } from '@/server/db/tables'; | ||
|
|
||
| async function getUserFromUsername(username: string) { | ||
| return await db.query.users.findFirst({ |
There was a problem hiding this comment.
Shouldn't this be findUnique? I don't really know much about this so maybe this is correct.
There was a problem hiding this comment.
findUnique is interchangable with findFirst when assuming all usernames are truly unique. Perhaps we should throw an error if there are multiple people with the same username? Or, we can just make sure to have proper username creation routines which will not result in conflicts.
No description provided.