Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebiten: retract RunGameOptions.StrictContextRestoration #3098

Closed
1 of 11 tasks
hajimehoshi opened this issue Sep 13, 2024 · 0 comments
Closed
1 of 11 tasks

ebiten: retract RunGameOptions.StrictContextRestoration #3098

hajimehoshi opened this issue Sep 13, 2024 · 0 comments

Comments

@hajimehoshi
Copy link
Owner

hajimehoshi commented Sep 13, 2024

Operating System

  • Windows
  • macOS
  • Linux
  • FreeBSD
  • OpenBSD
  • Android
  • iOS
  • Nintendo Switch
  • PlayStation 5
  • Xbox
  • Web Browsers

What feature would you like to be added?

RunGameOptions.StrictContextRestoration was introduced at #3083, but we realized that the current restoration implementation was not stable (though the code was the same as the previous one!), and perhaps just graceful shutting down for context losts (#3097) was enough in order to reduce ANR and crashes reported at the Play console.

We are now experimenting if the graceful-shutdown way would work well. If it works, I'll retract the option RunGameOptions.StrictContextRestoration before 2.8 is released. I don't remove the implementation of internal/restorable since possibly we might want to use it later in the future. If we don't need it for one year or so, we can remove internal/restorable again.

Why is this needed?

I don't want to add an uncertain thing to the public API.

@hajimehoshi hajimehoshi added this to the v2.8.0 milestone Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant