Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification is not showing correct info after trade is complete #6

Open
polymorpher opened this issue Dec 6, 2024 · 3 comments
Open

Comments

@polymorpher
Copy link

Bought the token using 5 ONE, but notification says I spent 10 ONE (should show both ONE and token amount)

image
@ArtemKolodko
Copy link
Collaborator

ArtemKolodko commented Dec 8, 2024

Fixed trade notification; added both token and ONE amounts:
34b591d
967e873

@polymorpher
Copy link
Author

Looks good. Let's use past tense (Bought, Sold, Spent)

@polymorpher
Copy link
Author

Also the notification is showing post-fee spending (or received amount). It is confusing to users (showing me that I spent 0.99, where I really spent 1.0). It should be precise about total amount and the fees charged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants