Disable outputEscape for some specific filters

[ybouane]

Hello,
I'm using the outputEscape option to escape output by default.
However, for some specific filters I want to disable the escaping, how can that be done?
How to integrate the functionality of the raw filter into my own filters. (I saw in the code that the raw filter is hardcoded :/ )

Example:
{{ "<b>Hello \nworld.</b>" }}
would output:
<b>hello world</b>

I made a nl2br filter:
const nl2br = function(str) {return escapeHtml(str).replace(/\r?\n/g, '<br>')};

So for:
{{ "<b>Hello \nworld.</b>" | nl2br }}
the output is:
<b>hello <br>world</b>
(it escapes twice)

Whereas I actually want:
&lt;b&gt;hello <br>world&lt;/b&gt;

The way to achieve that would be to type in {{ "<b>Hello \nworld.</b>" | nl2br | raw }} (and remove the escapeHtml step from the function), but I wanted to check if it was possible to avoid that?

I tried storing a variable isEscaped in the context of the nl2br filter and checking if is set on my outputEscape function which works in a simple use-case but fails in this example:
{% assign "a" | nl2br %} {{ "<b>Hello \nworld.</b>" }}

In this case, the second statement skips the escaping which is undesirable.

Thanks for your help!

[harttle]

outputEscape is undefined by default, {{ "<b>Hello \nworld.</b>" }} will output "<b>Hello \nworld.</b>" directly, by default.

I tried storing a variable isEscaped in the context of the nl2br filter

You're missing =, the correct syntax is:

{% assign foo = "<a>" | escape %}

Live demo: https://liquidjs.com/playground.html#eyUgYXNzaWduIGZvbyA9ICI8YT4iIHwgZXNjYXBlICV9Cnt7IGZvbyB9fQ==,e30=

[ybouane]

But I do want outputEscape to be enabled. I just want to disable it for specific filters such as the nl2br filter to avoid having to always use | raw everytine i need to use nl2br.

[ybouane]

Is there any solution to this?
Once again, I want outputEscape to be enabled but dynamically disable it if some specific filters are being used.

{{ foo }} // outputEscape is enabled
{{ foo | nl2br }} // outputEscape is disabled

That is because some filters like nl2br already escape the input.

For now the only solution is to do:
{{ foo | nl2br | raw }}

A way to solve this issue would be if it is possible for a filter to know which filters were called before itself?
Or to be able to mark multiple filters as "raw":

liquidjs/src/template/output.ts

Line 16 in 1380ac9

if (filters.length && filters[filters.length - 1].name === 'raw') {

[harttle]

Hi @ybouane , I took this approach

Or to be able to mark multiple filters as "raw":

And released this feature in v10.3.0, here's an example:

liquidjs/test/integration/liquid/register-filters.ts

Lines 53 to 62 in e6db371

	it('should not escape filter output when registered as "raw"', async () => {
	liquid.registerFilter('break', {
	handler: (str) => str.replace(/\n/g, '<br/>'),
	raw: true
	})
	const src = `{{ "a\nb" | break }}`
	const dst = 'a<br/>b'
	const html = await liquid.parseAndRender(src)
	return expect(html).to.equal(dst)
	})

[ybouane]

That's amazing! Thank you so much for addressing this!!