Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate whether to make getTokenInfo a view function #164

Closed
acuarica opened this issue Dec 21, 2024 · 1 comment · Fixed by #224
Closed

Evaluate whether to make getTokenInfo a view function #164

acuarica opened this issue Dec 21, 2024 · 1 comment · Fixed by #224
Assignees
@arianejasuwienas
Labels
feature Enhancing an existing feature driven by business requirements. Typically backwards compatible.

Comments

@acuarica
Copy link
Contributor

In our HTS emulation, the getTokenInfo function is currently declared as non-view. This is to mimic the declaration in the Smart Contracts repo.

Nevertheless, getTokenInfo from services (real HTS) also works when this function is declared as view. We should evaluate whether to change it to view to improve user usability.

See issue hashgraph/hedera-smart-contracts#1116 to track efforts to make it view function in the Smart Contracts repo.
@acuarica acuarica added the feature Enhancing an existing feature driven by business requirements. Typically backwards compatible. label Dec 21, 2024
@acuarica acuarica mentioned this issue Jan 11, 2025
Open
@arianejasuwienas arianejasuwienas mentioned this issue Jan 30, 2025
Merged
2 tasks
arianejasuwienas added a commit that referenced this issue Jan 30, 2025
@arianejasuwienas
feat: making gettokeninfo a view function (#164)
5a5f6f7 
Signed-off-by: Mariusz Jasuwienas <[email protected]>
@arianejasuwienas
Copy link
Contributor

Since our goal is to make the forked solution as similar to the production environment as possible, we should wait to proceed with this task until hashgraph/hedera-smart-contracts#1116 is completed.

However, if this change becomes necessary and is not blocked by smart contract modifications, we can revive this PR: #224 .

@arianejasuwienas arianejasuwienas self-assigned this Jan 30, 2025
@arianejasuwienas arianejasuwienas moved this from Backlog to Blocked in Smart Contract Sprint Board Jan 30, 2025
arianejasuwienas added a commit that referenced this issue Jan 30, 2025
@arianejasuwienas
feat: getnftinfo will return its metadata and creation time (#164)
7134471 
Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas added a commit that referenced this issue Feb 12, 2025
@arianejasuwienas
feat: making tests views where it is possible (#164)
5b8578c 
Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas added a commit that referenced this issue Feb 12, 2025
@arianejasuwienas
feat: making gettokeninfo a view function (#164)
a9b7a60 
Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas added a commit that referenced this issue Feb 12, 2025
@arianejasuwienas
feat: making tests views where it is possible (#164)
5323a8f 
Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas added a commit that referenced this issue Feb 12, 2025
@arianejasuwienas
feat: making tests added after this pr was created views (#164)
5ab698c 
Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas added a commit that referenced this issue Feb 12, 2025
@arianejasuwienas
feat: making gettokeninfo a view function (#164)
94b6e2e 
Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas added a commit that referenced this issue Feb 12, 2025
@arianejasuwienas
feat: making gettokeninfo and its dependants a view function (#164) (#…
0fe9477 
…224)

Signed-off-by: Mariusz Jasuwienas <[email protected]>
@github-project-automation github-project-automation bot moved this from In Review to Done in Smart Contract Sprint Board Feb 12, 2025
arianejasuwienas added a commit that referenced this issue Feb 13, 2025
@arianejasuwienas
feat: making gettokeninfo and its dependants a view function (#164) (#…
122e436 
…224)

Signed-off-by: Mariusz Jasuwienas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arianejasuwienas arianejasuwienas

Labels
feature Enhancing an existing feature driven by business requirements. Typically backwards compatible.
Projects
Smart Contract Sprint Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: making gettokeninfo and its dependants a view function (#164) hashgraph/hedera-forking
2 participants
@acuarica @arianejasuwienas