-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mirror node importer to support download stream files form subpath of a storage bucket. #10026
Comments
Hi, I would like to work on this issue if no one else is currently working on it. |
@HarshSawarkar thanks. I have assigned the ticket to you and added a brief solution in the ticket. let me know if you have any questions. |
@xin-hedera Thanks for your response. I have raised a PR with the changes mentioned in the ticket. Could you please review it? |
Also, I ran the
Expected: onError(RuntimeException)
Expected: onError(RuntimeException) |
perhaps they are flaky, can ignore. |
Yeah, sure, will do. |
@xin-hedera I'm looking to work on some meaningful issues. Could you please guide me on where to start? |
Hi @HarshSawarkar. Thanks for all your efforts thus far contributing to Hedera! Our two main focus areas right now that we need help on are #8834 and #8828. For block stream, help with one of the transformer tickets might be the easiest. If you're interested in learning more about EVMs, the modularized EVM epic could use help fixing the numerous tests broken when |
@steven-sheehy Thank you for your response! I will review the tickets mentioned and conduct some research around them. I will reach out to you or @xin-hedera on Discord if I come across any issues within either of the tickets that I would like to work on or if I have any doubts. |
Problem
Currently mirror node importer can only download stream files from storage with a specific bucket, then import stream files into database
We request importer to be able to download stream files from subpath of a bucket
or
This is because when running different test with solo deployment,
without subpath support, all these tests would write to the same buckets.
We could workaround the issue with creating different buckets for different test runs, but GCS has limit of how many and how fast bucket can be created.
So it is required to have importer to support subpath in order to run relatively large number of tests parallely.
Once the feature is implemented, please also update helm chart to expose any changes
so solo chart can utilize the newly implemented feature.
Solution
Mirror node importer to support subpath of a giving storage bucket.
String pathPrefix
to classCommonDownloaderProperties
, default to empty stringS3StreamFileProvider.getPrefix
, conditionally prependpathPrefix
if it's not emptyAlternatives
No response
The text was updated successfully, but these errors were encountered: