Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[req] Purge synced services on exit #10

Open
dekimsey opened this issue Feb 19, 2019 · 2 comments
Open

[req] Purge synced services on exit #10

dekimsey opened this issue Feb 19, 2019 · 2 comments

Comments

@dekimsey
Copy link

dekimsey commented Feb 19, 2019

Currently, consul-aws publishes the consul services and nodes. But does not clean-up after itself on exit. When we stopped the services and removed the container daemon we found all services were still listed.

I found this out when I decided to remove the discovery zone (via Terraform). AWS Cloud Map will not let one delete the zone until all services are deleted, and one cannot remove a service until all instances are deleted. There was much ... clicking that day.

Thank you

@hanshasselberg
Copy link
Member

This is intentional, because I think in case consul-aws crashes, it is better if everything stays the way it was.
But I think we maybe could add a helper to delete everything consul-aws created?!

@dekimsey
Copy link
Author

dekimsey commented Mar 12, 2019

I feel that if consul-esm (as a daemon) terminates, then it should remove its synced services. I don't have any reason to expect them to survive. It's been awhile but does consul-aws gracefully lock on who is syncing to AWS? That might be an easy way to address crashing issues of a single instance.

Honestly, it wouldn't be so painful if the AWS interface for removing dead entries was better.

edit: A helper would be great regardless!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants