From 91cf02f83ecbfee8d51cd19a827a436011bf01fa Mon Sep 17 00:00:00 2001 From: jukie <10012479+Jukie@users.noreply.github.com> Date: Wed, 3 Apr 2024 21:00:48 -0600 Subject: [PATCH] Update comment --- control-plane/catalog/to-consul/resource.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/control-plane/catalog/to-consul/resource.go b/control-plane/catalog/to-consul/resource.go index c32345ba16..47917c9cc5 100644 --- a/control-plane/catalog/to-consul/resource.go +++ b/control-plane/catalog/to-consul/resource.go @@ -742,7 +742,8 @@ func (t *ServiceResource) registerServiceInstance( } } for _, endpoint := range endpointSlice.Endpoints { - // From Kubernetes docs nil is an unknown state that can be interpreted as the endpoint being in a ready state + // From Kubernetes docs nil is an unknown state that can be interpreted as + // the endpoint being in a non-terminating state (assume ready or at least a state we shouldn't ignore) // Ref: https://github.com/kubernetes/api/blob/5147c1a32f6a0b9b155bb84e59f933e0ff8a3792/discovery/v1/types.go#L129-L137 if endpoint.Conditions.Terminating == nil || !*endpoint.Conditions.Terminating { for _, endpointAddr := range endpoint.Addresses {