Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deregister services after unhealthy #1825

Open
javiermendozain opened this issue Jan 10, 2023 · 3 comments
Open

Deregister services after unhealthy #1825

javiermendozain opened this issue Jan 10, 2023 · 3 comments
Labels
type/bug Something isn't working

Comments

@javiermendozain
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Overview of the Issue

  • Deregister services after unhealthy
    We scale down the microservices massively (ej: 10 to 1 pod ), and some instance services don't deregister.
    All the microservices use a deregister process when they are dying, so we used DeregisterCriticalServiceAfter property to ensure deregistering on consul but the minimal delay is one minute and I want to deregister immediately or auto deregister after fail health check configurable through some property.

Somebody had the same situation?

Reproduction Steps

Scenario: consul image: 1.14.2, using 3 server
We have terragrunt and terraform, using the default value.yaml, and replace those properties👇:

{
"server.replicas" = 3
"client.enabled" = false
"connectInject.enabled" = false
"syncCatalog.enabled" = false
"global.acls.manageSystemACLs" = false
"global.acls.nodeSelecor" = "group:kafka"
}

When: we scale down the microservices massively (ej: 10 to 1 pod ), some instance services don't deregister

Logs

image

image

image

The consul server not found the service
image

2023-01-10T20:52:07.135Z [ERROR] agent.http: Request error: method=PUT url="/v1/agent/service/deregister/ef52afee-c25e-464a-a0e1-32df4c0d6878?merge-central-config=&near=_agent&node-meta=sd-consul-server-1%3Asd-consul-server-1" from=172.24.13.235:49322 error="Unknown service ID "ef52afee-c25e-464a-a0e1-32df4c0d6878". Ensure that the service ID is passed, not the service name."
2023-01-10T20:52:07.158Z [ERROR] agent.http: Request error: method=PUT url="/v1/agent/service/deregister/ef52afee-c25e-464a-a0e1-32df4c0d6878?merge-central-config=&near=_agent&node-meta=sd-consul-server-1%3Asd-consul-server-1" from=172.24.13.235:49322 error="Unknown service ID "ef52afee-c25e-464a-a0e1-32df4c0d6878". Ensure that the service ID is passed, not the service name."

Expected behavior

Environment details

Consul: 1.14.2
the microservices are using consul client on Golang (v1.15.2) and .NET (1.6.10.8)

  • To .NET
    <PackageReference Include="Consul" Version="1.6.10.8" />

  • To Golang
    github.com/hashicorp/consul/api v1.15.2

  • K8S Version: 1.23.12

  • values.yaml used to deploy the helm chart:

  • Clour Provider: Azure Kubernetes

Additional Context

@javiermendozain javiermendozain added the type/bug Something isn't working label Jan 10, 2023
@Juandavi1
Copy link

Hi ! Same here !

@javiermendozain
Copy link
Author

Hi @blake @david-yu, @ishustava
Hope you are so well ,
I would to know if it is clear the issue that I've commented on or do you have some recommendations for this one.?

@MageshSrinivasulu
Copy link

Facing similar issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants