-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce permissions of API gateway policy #3230
Conversation
27d791c
to
30ee813
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. Have you had a chance to test it yet? If not, I can help out with that
30ee813
to
a71a1ee
Compare
I have confirmed that this works for native Consul API Gateway using the setup here, resulting in: $ http http://34.148.240.250 -j
HTTP/1.1 200 OK
content-length: 255
content-type: text/plain; charset=utf-8
date: Thu, 07 Dec 2023 20:00:41 GMT
server: envoy
x-envoy-upstream-service-time: 5
{
"body": "Hello World",
"code": 200,
"duration": "146.643µs",
"end_time": "2023-12-07T20:00:41.767760",
"ip_addresses": [
"10.40.2.8"
],
"name": "backend",
"start_time": "2023-12-07T20:00:41.767613",
"type": "HTTP",
"uri": "/"
} I have also confirmed that everything still works for legacy Consul API Gateway using the setup here, resulting in: $ http http://104.196.141.50 -j
HTTP/1.1 200 OK
content-length: 256
content-type: text/plain; charset=utf-8
date: Thu, 07 Dec 2023 20:44:36 GMT
server: envoy
x-envoy-upstream-service-time: 10
{
"body": "Hello World",
"code": 200,
"duration": "463.781µs",
"end_time": "2023-12-07T20:44:36.868101",
"ip_addresses": [
"10.40.5.10"
],
"name": "backend",
"start_time": "2023-12-07T20:44:36.867637",
"type": "HTTP",
"uri": "/"
} |
Changes proposed in this PR: