Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed acl deletetion in endpoints controller (#3210) #3279

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

aahel
Copy link
Contributor

@aahel aahel commented Nov 28, 2023

Changes proposed in this PR:

How I've tested this PR:

How I expect reviewers to test this PR:

Checklist:

* fixed acl deletetion in endpoints controller

* fixed tests

* fixed other tests

* fixed ent tests

* added changelog

* updated TestReconcileDeleteEndpoint to support deleting token by pod uid

* passed pod-uid to dataplane

* fixed tests

* fixed more tests

* fixed dataplane env

* fixed test

* fixed passing env to dataplane

* fixed unit test
@hashicorp-cla
Copy link

hashicorp-cla commented Nov 28, 2023

CLA assistant check
All committers have signed the CLA.

@aahel aahel changed the base branch from main to release/1.0.x November 28, 2023 10:44
@aahel aahel added the pr/no-backport signals that a PR will not contain a backport label label Nov 28, 2023
@aahel aahel enabled auto-merge (squash) November 28, 2023 10:59
@aahel aahel disabled auto-merge November 28, 2023 11:20
@aahel aahel changed the title Backport/net 5174/anonymous token policy/1.0 fixed acl deletetion in endpoints controller (#3210) Nov 28, 2023
@aahel aahel enabled auto-merge (squash) November 28, 2023 12:30
@hashi-derek
Copy link
Member

Closing / reopening this PR to trigger the CICD pipeline again.

auto-merge was automatically disabled November 28, 2023 14:14

Pull request was closed

@hashi-derek hashi-derek reopened this Nov 28, 2023
@aahel aahel merged commit e69eb80 into release/1.0.x Nov 28, 2023
8 checks passed
@aahel aahel deleted the backport/NET-5174/anonymous-token-policy/1.0 branch November 28, 2023 15:19
@aahel aahel added the consul-india PRs/Issues assigned to Consul India team label Dec 27, 2023
@aahel aahel self-assigned this Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consul-india PRs/Issues assigned to Consul India team pr/no-backport signals that a PR will not contain a backport label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants