NET-6722 Rename MeshConfigController to ConsulResourceController #3283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-eckert
added
pr/no-changelog
added 5 commits
November 29, 2023 12:44
control-plane/config-entries/controllersv2/gateway_class_config_controller.go
Outdated
Show resolved
Hide resolved
|
looks like there are some linter errors that need cleaning up.. based on the cursory look, it seems fairly straightforward. let me know if you need hellp with those |
Yeah, it looks like an update to the retry linter caught some lingering issues. The EDIT: I'm going to fix this in another PR then rebase this PR. EDIT 2: In the meantime, I loosened the restriction so others are unblocked. |
sarahalsmiller
pushed a commit
that referenced
this pull request
Jan 5, 2024
* Refactor MeshConfigController to ConsulResouceController * Rename controller file * Rename MeshConfig to ConsulResource * Rename Controller to ResourceController * Update some references to meshConfig * Fixup some comments * Change MeshConfigController to ConsulResourceController in all implementations * Change MeshConfigController to ConsulResourceController in instances * Fix references to MeshConfigController in some tests * Rename mockMeshConfig to mockConsulResource * Rename meshConfigReconciler to consulResourceReconciler * Rename ConsulResourceController to Controller * Fix calls to validate * Use "Controller" instead of "Reconciler" * Empty commit to retrigger tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The names
MeshConfigControllerandMeshConfigwere initially chosen to represent the generic Consul Resource mapping from Kubernetes into Consul.Previously, these resources were referred to as "config-entries". With the upcoming implementation of Mesh Gateways V2, there was a name conflict with that implementation's
MeshConfigurationresource andMeshConfigurationController.It was decided that the existing generic
MeshConfigusage be replaced withConsulResource. This PR adopts that naming scheme.This change is not user-facing.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: