Fix Some Flakey Tests #3304
Closed
Fix Some Flakey Tests #3304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilkermichael
added
pr/no-backport
wilkermichael
force-pushed
the
mw/NET-5808-1-18-pipeline-flaky-tests
branch
3 times, most recently
from
757e724 to
85ee862
Compare
wilkermichael
commented
Dec 7, 2023
| @@ -350,7 +368,7 @@ func TestPeering_Connect(t *testing.T) { | |||
| // If ACLs are enabled, test that deny intentions prevent connections. | |||
| if c.ACLsEnabled { | |||
| logger.Log(t, "testing intentions prevent connections through the terminating gateway") | |||
| k8s.CheckStaticServerConnectionFailing(t, staticClientOpts, staticClientName, externalServerHostnameURL) | |||
| k8s.CheckStaticServerHTTPConnectionFailing(t, staticClientOpts, staticClientName, externalServerHostnameURL) | |||
There was a problem hiding this comment.
@t-eckert this is the fix for the flake we talked about
wilkermichael
force-pushed
the
mw/NET-5808-1-18-pipeline-flaky-tests
branch
2 times, most recently
from
b78156c to
9a89883
Compare
… before proceeding
- test was performing the wrong connection check, since http should be checking for a '403' - added cluster creation in parallel to speed up test
wilkermichael
force-pushed
the
mw/NET-5808-1-18-pipeline-flaky-tests
branch
from
9a89883 to
e7cee85
Compare
|
I'm moving the fix for the transparent proxy test error to a different PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
👀
Checklist: