Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bold section headers in PR template #3313

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Bold section headers in PR template #3313

merged 3 commits into from
Dec 6, 2023

Conversation

nathancoleman
Copy link
Member

@nathancoleman nathancoleman commented Dec 6, 2023 •
edited
Loading

Changes proposed in this PR

  • Bold the section headers in the PR template so that they stand out even when there's a significant amount of text in the PR body

How I've tested this PR

👀

How I expect reviewers to test this PR

👀

Checklist

@nathancoleman nathancoleman added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport signals that a PR will not contain a backport label labels Dec 6, 2023
@t-eckert
Copy link
Contributor

t-eckert commented Dec 6, 2023

Why not use ## so it works for screen readers too?

zalimeni
zalimeni approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@zalimeni zalimeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks! I agree w/ @t-eckert it might be ideal to use headings, maybe even ### to make the overall view easier on the eyes.

@nathancoleman
Copy link
Member Author

Good call gents, done!

@nathancoleman nathancoleman enabled auto-merge (squash) December 6, 2023 20:36
@nathancoleman nathancoleman merged commit 1682744 into main Dec 6, 2023
3 checks passed
@nathancoleman nathancoleman deleted the pr-template-bolding branch December 6, 2023 21:10
sarahalsmiller pushed a commit that referenced this pull request Jan 5, 2024
@nathancoleman @sarahalsmiller
Bold section headers in PR template (#3313)
1dbd71d 
* Bold section headers in PR template

* Use proper header markers instead of just bolding

* Update pull_request_template.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zalimeni zalimeni zalimeni approved these changes

@t-eckert t-eckert t-eckert approved these changes

@curtbushko curtbushko Awaiting requested review from curtbushko

Assignees
No one assigned
Labels
pr/no-backport signals that a PR will not contain a backport label pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nathancoleman @t-eckert @zalimeni