Support WAN Address Annotations #3420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-eckert
added
pr/no-changelog
|
The original story for this wanted the values to be set on the GatewayClassConfig by extending its configuration. Talking it over with Nate and Melisa, we decided to add the annotations directly on the Mesh Gateway CRD and patch those through. That way, we don't get mesh gateway specific config on a "general gateway" configuration object. Also, we aren't sure if we will need these annotations in V2 and if we don't, this model is a bit easier to remove. |
t-eckert
commented
Dec 21, 2023
|
|
||
| # Validation | ||
| # For meshGateway.wanAddress, static must be set if source is "Static" | ||
| {{if (and (eq .Values.meshGateway.wanAddress.source "Static") (eq .Values.meshGateway.wanAddress.static ""))}}{{fail ".meshGateway.wanAddress.static must be set to a value if .meshGateway.wanAddress.source is Static"}}{{ end }} |
There was a problem hiding this comment.
I added validation here that will block the invalid config of a "Static" address with no address set.
t-eckert
force-pushed
the
NET-6828/support-wan-address-annotations
branch
from
d8d6789 to
5ef1cde
Compare
missylbytes
reviewed
Jan 3, 2024
| @@ -2,18 +2,20 @@ | |||
|
|
|||
| load _helpers | |||
|
|
|||
| target=templates/gateway-resources-configmap.yaml | |||
missylbytes
approved these changes
Jan 3, 2024
jm96441n
pushed a commit
that referenced
this pull request
Jan 3, 2024
* Add wanAddress configuration to the configmap * Set the annotations on the mesh gateway CRD * Patch through the annotations from the Mesh Gateway * Fix Job -> ConfigMap * Use JSON to compare annotations * Add annotations to deployment test * Fix checking annotations in helm tests
sarahalsmiller
pushed a commit
that referenced
this pull request
Jan 5, 2024
* Add wanAddress configuration to the configmap * Set the annotations on the mesh gateway CRD * Patch through the annotations from the Mesh Gateway * Fix Job -> ConfigMap * Use JSON to compare annotations * Add annotations to deployment test * Fix checking annotations in helm tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
How I've tested this PR
I added BATs and I ran a deployment with the following configuration:
Which produced a mesh gateway with the correct configuration.
How I expect reviewers to test this PR
Checklist