Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tolerations to init job templates #3433

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

L1ghtman2k
Copy link

Changes proposed in this PR

  • Add the ability to specify tolerations for tls-init-job, tls-init-cleanup-job, and gossip-encryption-autogenerate-job.
  • Add associated unit tests.
  • Currently, these initialization jobs will get stuck in a 'Pending' state if all nodes in the default namespace have NoSchedule taints. Specifying tolerations allows the jobs to be scheduled.

How I've tested this PR

  • The template unit tests provided, and those added.
  • Deployment against a private K8s cluster, verifying tolerations on init jobs.

How I expect reviewers to test this PR

  • Configure K8s test cluster with NoSchedule taints on all nodes. Deploy Consul with tls and gossipEncryption enabled, and tolerations defined for both. Inspect init jobs for expected tolerations and ensure they are not stuck in a 'Pending' state.

Checklist

@hashicorp-cla
Copy link

hashicorp-cla commented Jan 4, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants