gRPC port is exposed even if gRPC is disabled #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
d-mosinski-s
changed the title
d-mosinski-s
force-pushed
the
fix_grpc_nodeport
branch
from
abe5b0c to
254407c
Compare
|
Added changelog and tests. |
d-mosinski-s
force-pushed
the
fix_grpc_nodeport
branch
from
8d81780 to
a1c355e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
Disable gRPC node port 8502 when client gRPC is disabled
How I've tested this PR
Added changelog and tests.
It was also tested by running modified chart from local code.
How I expect reviewers to test this PR
gRPC node port 8502 should be disabled in consul client when client.grpc is disabled. Currently it is conflicting with server grpc node port when running server and client same node.
Similar if should be applied to server template (do not expose 8502 when connect: is disabled) but maybe in different PR.
Checklist