Backport of [NET-7657,NET-6934] Define v2 GatewayClass + GatewayClassConfig locally into release/1.4.x #3572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nathancoleman
force-pushed
the
backport/k8s-native-gateway-class/easily-relative-satyr
branch
from
aeb3256 to
138a67a
Compare
…ly (#3559) * Define GatewayClass's spec model locally instead of consuming proto from Consul * Update gateway resources job to use new types, constants * Make description optional, regenerate CRD definitions * Remove GatewayClass columns related to syncing into Consul
nathancoleman
force-pushed
the
backport/k8s-native-gateway-class/easily-relative-satyr
branch
from
138a67a to
e8d385b
Compare
nathancoleman
approved these changes
Feb 7, 2024
nathancoleman
deleted the
backport/k8s-native-gateway-class/easily-relative-satyr
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #3559 to be assessed for backporting due to the inclusion of the label backport/1.4.x.
The below text is copied from the body of the original PR.
Changes proposed in this PR
The
specfield for v2GatewayClasses currently uses the proto-public definitions from Consul; however, we don't want to do that anymore since Consul has no need for this type at all.We've already broken this dependency for
GatewayClassConfigin the past but need to do the same forGatewayClassso that we can remove the proto definition from Consul altogether.How I've tested this PR
helm installwith.meshGateway.enabled=trueand.global.imageK8Sset to the build of this branchHow I expect reviewers to test this PR
See above
Checklist
Overview of commits