make missing changes in the backport #4260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xwa153
added
pr/no-changelog
missylbytes
approved these changes
Aug 21, 2024
missylbytes
approved these changes
Aug 21, 2024
zalimeni
approved these changes
Aug 21, 2024
|
@wangxinyi7 LGTM! Minor thing, in this and the 1.4.x PR, would you mind updating the PR and commit text to describe the change so it's clear that this fixes the Thanks for fixing this! |
xwa153
force-pushed
the
make-up-missing-change-in-backport
branch
from
82704ff to
6ae5f76
Compare
Thanks for catching up, yup, just updated the description of the PR and the commit message for this and the other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
Fix the missing argument in the path of the LICENSE file
ticket
Follow-up to #3938.
How I've tested this PR
How I expect reviewers to test this PR
Checklist