Fix flaky workspace/symbol tests
#1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This flaky failure is unrelated I guess? 😄 
|
Yeah, I will look into that one next. This PR is about |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
workspace/symboltests, we'll send multipledidOpenrequests for files in the same directory. The first request will trigger parsing of the whole directory (which is empty on disk) and set the module state to "loaded". The seconddidOpenwill then do nothing, as it will respect the state already marked as loaded.Depending on the order of execution, sometimes both files are opened before the first parsing job runs, sometimes the job runs between the two calls, causing the test to fail.
By writing the files to disk first, we ensure that both are parsed by the first
didOpencall.