Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add groups param to kubernetes_certificate_signing_request 🖊️ #1814

Closed
yuriy-yarosh opened this issue Aug 25, 2022 · 2 comments
Closed

Comments

@yuriy-yarosh
Copy link

yuriy-yarosh commented Aug 25, 2022

Description

K8S CSR's for kubernetes.io/kubelet-serving signer have groups param, and it's a part of the CSR spec.

It's missing in kubernetes_certificate_signing_request resource.

Potential Terraform Configuration

# For Vault Standalone TLS certs provisioning according to 
# https://www.vaultproject.io/docs/platform/k8s/helm/examples/standalone-tls

resource "kubernetes_certificate_signing_request" "tls" {
  metadata {
    name = "vault-csr"
  }

  auto_approve = true

  spec {
    usages      = ["digital signature", "key encipherment", "server auth"]
    signer_name = "kubernetes.io/kubelet-serving"
    request     = tls_cert_request.csr.cert_request_pem
    groups      = ["system:authenticated"]
  }
}

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@github-actions
Copy link

github-actions bot commented Sep 3, 2023

Marking this issue as stale due to inactivity. If this issue receives no comments in the next 30 days it will automatically be closed. If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. This helps our maintainers find and focus on the active issues. Maintainers may also remove the stale label at their discretion. Thank you!

@github-actions github-actions bot added the stale label Sep 3, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 4, 2023
@MicheleArturo
Copy link

Are there any plans to address this request?

@github-actions github-actions bot removed the stale label Nov 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants