Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Clean up test-infra and tools #2313

Merged
merged 4 commits into from
Oct 13, 2023
Merged

🧹 Clean up test-infra and tools #2313

merged 4 commits into from
Oct 13, 2023

Conversation

arybolovlev
Copy link
Contributor

@arybolovlev arybolovlev commented Oct 13, 2023

Description

The following changes have been done:

  • Move aks-new to aks -- that is why changes look massive.
  • Pin AWS and EKS provider versions.
  • Split infra code: move variables to variables.tf and outputs to outputs.tf.
  • Remove unused code from tools.
  • Run terraform fmt in test-infra.
  • Rename acceptance test job names.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

Release Note

Release note for CHANGELOG:

NONE.

References

N/A.

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@arybolovlev arybolovlev marked this pull request as ready for review October 13, 2023 17:05
@arybolovlev arybolovlev requested a review from a team as a code owner October 13, 2023 17:05
Copy link
Contributor

@sheneska sheneska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! 🚀

@arybolovlev
Copy link
Contributor Author

GKE tests are failing for service-related tests due to some changes on the Google end. I will go ahead and merge this PR since it cleans up workflow and infra code and raise a new one to fix tests.

@arybolovlev arybolovlev merged commit 3655fa7 into main Oct 13, 2023
15 of 16 checks passed
@arybolovlev arybolovlev deleted the update-workflow branch October 13, 2023 18:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants