You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If a PR is adding unit tests it is unclear where in the PR's checks the unit tests are running. There is a clear check for acceptance tests, but there isn't an equivalent for unit tests:
Potential Terraform Configuration Change
We could update the existing acceptance tests check run only acceptance tests (filter tests by TestAcc prefix) and have a separate check that's specific to unit tests (e.g achieved by having TF_ACC environment variable unset).
Discussion from triage: Select for unit tests using a negated regex similar to ^Test[^Ac]{3}.*$ - though this example would accidentally exclude TestAAA..., Testccc.... Another option could be Test(?!Acc) if it's compatible with go test.
Description
If a PR is adding unit tests it is unclear where in the PR's checks the unit tests are running. There is a clear check for acceptance tests, but there isn't an equivalent for unit tests:
Potential
Terraform ConfigurationChangeWe could update the existing acceptance tests check run only acceptance tests (filter tests by
TestAcc
prefix) and have a separate check that's specific to unit tests (e.g achieved by havingTF_ACC
environment variable unset).References
Community Note
The text was updated successfully, but these errors were encountered: