feat: added "strategy.rolling_update.max_surge" attr to daemonset #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sheneska
reviewed
Feb 13, 2024
There was a problem hiding this comment.
Hi @manjinder-mckc, thank you for these changes! Please take a look at the comment I left in the code.
| Description: "The maximum number of nodes with an existing available DaemonSet pod that can have an updated DaemonSet pod during during an update. Value can be an absolute number (ex: 5) or a percentage of desired pods (ex: 10%). This can not be 0 if MaxUnavailable is 0. Absolute number is calculated from percentage by rounding up to a minimum of 1. Default value is 0. Example: when this is set to 30%, at most 30% of the total number of nodes that should be running the daemon pod (i.e. status.desiredNumberScheduled) can have their a new pod created before the old pod is marked as deleted.", | ||
| Optional: true, | ||
| Default: "0", | ||
| ValidateFunc: validation.StringMatch(regexp.MustCompile(`^([0-9]+|[0-9]+%|)$`), ""), |
There was a problem hiding this comment.
This expression allows percentages higher than 100, here is an example that captures a more precise range of values.
|
Quick check-in on this PR. @manjinder-mckc please take a look at our comment and let us know if you have any questions with the suggested improvement. We would love to move forward with merging. Thanks! |
|
@iBrandyJackson @sheneska Apologies for late reply. Thank you for reviewing. I will take a look and pick this up now. |
|
Hi @manjinder-mckc ! any help needed for this? |
|
closing in favor of #2609 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhancement: #2106
Acceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
Community Note