-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added "strategy.rolling_update.max_surge" argument to kubernetes_daemon_set_v1
#2609
Conversation
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
kubernetes_daemon_set_v1
This reverts commit d951b28.
When can we expect this to be merged/released? Look forward to this feature, as the workaround option of using manifest also does not work and has PR open since February. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both failing tests are unrelated to changes made in this PR. Thanks for working on this!
Description
Adds support for the rollingUpdate.maxSurge property for DaemonSets. See #2106
There is admittedly already a PR for this (PR #2416), but that is slightly out of date in terms of the documentation structure and I started this branch before I realized it existed.
Acceptance tests
Output from acceptance testing:
I am currently struggling to actually run any of the makefile builds, which may be due to something in my WSL setup.
Release Note
Release note for CHANGELOG:
References
Related Issue: #2106
Terraform documentation: https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/daemonset#rolling_update
Kubernetes documentation: https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/daemon-set-v1/#:~:text=updateStrategy.rollingUpdate.-,maxSurge,-(IntOrString)
Community Note