Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added "strategy.rolling_update.max_surge" argument to kubernetes_daemon_set_v1 #2609

Merged
merged 9 commits into from
Nov 18, 2024

Conversation

theonlyames
Copy link
Contributor

@theonlyames theonlyames commented Oct 24, 2024

Description

Adds support for the rollingUpdate.maxSurge property for DaemonSets. See #2106

There is admittedly already a PR for this (PR #2416), but that is slightly out of date in terms of the documentation structure and I started this branch before I realized it existed.

Acceptance tests

  • [Y] Have you added an acceptance test for the functionality being added?
  • [N] Have you run the acceptance tests on this branch?

Output from acceptance testing:

I am currently struggling to actually run any of the makefile builds, which may be due to something in my WSL setup.

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

`resources_kubernetes_daemon_set_v1` : Added `max_surge` argument for to `rolling_update` block. 

References

Related Issue: #2106
Terraform documentation: https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/daemonset#rolling_update

Kubernetes documentation: https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/daemon-set-v1/#:~:text=updateStrategy.rollingUpdate.-,maxSurge,-(IntOrString)

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Copy link

hashicorp-cla-app bot commented Oct 24, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@theonlyames theonlyames changed the title Updated Kubernetes Daemonset RollingUpdate to support the maxSurge pr… feat: added "strategy.rolling_update.max_surge" argument to kubernetes_daemon_set_v1 Oct 24, 2024
@theonlyames theonlyames marked this pull request as ready for review October 24, 2024 18:34
@theonlyames theonlyames requested a review from a team as a code owner October 24, 2024 18:34
@BBBmau BBBmau added this to the v2.34.0 milestone Oct 24, 2024
2609.txt Outdated Show resolved Hide resolved
@alexp-openai
Copy link

When can we expect this to be merged/released? Look forward to this feature, as the workaround option of using manifest also does not work and has PR open since February.

@BBBmau BBBmau requested a review from a team as a code owner November 18, 2024 19:11
Copy link
Contributor

@BBBmau BBBmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both failing tests are unrelated to changes made in this PR. Thanks for working on this!

@BBBmau BBBmau merged commit bcd95fd into hashicorp:main Nov 18, 2024
23 of 25 checks passed
@sheneska sheneska mentioned this pull request Nov 21, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants