Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Handle Jobs with ttl_seconds_after_finished = 0 correctly" #2650

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Revert "Handle Jobs with ttl_seconds_after_finished = 0 correctly" #2650

merged 3 commits into from
Dec 20, 2024
+7 −113

Conversation

justinmchase
Copy link
Contributor

@justinmchase justinmchase commented Dec 16, 2024 •
edited
Loading

Reverts #2596

Per issue #2649, please revert this breaking change which regresses a critical feature.

@justinmchase justinmchase requested a review from a team as a code owner December 16, 2024 19:12
@hashicorp-cla-app HashiCorp CLA App
Copy link

hashicorp-cla-app bot commented Dec 16, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hashicorp-cla-app HashiCorp CLA App
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

arybolovlev
arybolovlev requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@arybolovlev arybolovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @justinmchase,

Thank you for reverting this change and properly reporting the related issue. Indeed, it looks like a breaking change and we need to find a better way to cover both scenarios without introducing a breaking change in the minor release.

I have left a small comment. Once it is addressed we can merge this change and cut a patch release.

.changelog/2596.txt Outdated Show resolved Hide resolved
@justinmchase
Copy link
Contributor Author

I updated the release notes files as requested and merged upstream main.

arybolovlev
arybolovlev approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@arybolovlev arybolovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @justinmchase!

@arybolovlev arybolovlev merged commit 7246275 into hashicorp:main Dec 20, 2024
22 of 25 checks passed
@justinmchase justinmchase deleted the revert-2596-fix-job-ttl-zero-handling branch December 20, 2024 15:56
JaylonmcShan03 pushed a commit that referenced this pull request Jan 9, 2025
@justinmchase @JaylonmcShan03
Revert change introduced in PR 2596: Handle Jobs with ttl_seconds_aft…
8e20b79 
…er_finished = 0 correctly (#2650)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arybolovlev arybolovlev arybolovlev approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinmchase @arybolovlev