Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of lease_renewal_threshold via vault agent sidecar annotations #706

Open
hgadatia opened this issue Nov 19, 2024 · 0 comments · May be fixed by #721
Open

Allow configuration of lease_renewal_threshold via vault agent sidecar annotations #706

hgadatia opened this issue Nov 19, 2024 · 0 comments · May be fixed by #721
Labels
enhancement New feature or request

Comments

@hgadatia
Copy link

Is your feature request related to a problem? Please describe.
Currently for non-renewable leased secrets the secret is refreshed at the 90% mark based on the doc. We would like to be able to configure this via side car annotations since our application requirement for high availability is to be able to refresh the creds at the 50% mark so we have a good buffer between the old and new cred being valid in case there is a vault outage in our org.

lease_renewal_threshold

Describe the solution you'd like
Would like to be able to set this via vault agent side car annotations similar to what can be set currently for this parameter in the template_config

https://developer.hashicorp.com/vault/docs/platform/k8s/injector/annotations#vault-hashicorp-com-template-config-exit-on-retry-failure

Describe alternatives you've considered
Not sure if there are any other alternatives.

Additional context
Add any other context or screenshots about the feature request here.

@hgadatia hgadatia added the enhancement New feature or request label Nov 19, 2024
@phuhung273 phuhung273 linked a pull request Dec 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant