Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics unit test #709

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Add metrics unit test #709

merged 2 commits into from
Dec 2, 2024

Conversation

tvoran
Copy link
Member

@tvoran tvoran commented Dec 2, 2024

Test the init/sidecar/both logic for telemetry added in #703

@tvoran tvoran requested a review from benashz December 2, 2024 20:21
@tvoran tvoran requested a review from a team as a code owner December 2, 2024 20:21
@tvoran tvoran added this to the 1.6.0 milestone Dec 2, 2024
benashz
benashz approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tvoran
Copy link
Member Author

tvoran commented Dec 2, 2024

Thanks!

@tvoran tvoran merged commit e7653f2 into main Dec 2, 2024
11 checks passed
@tvoran tvoran deleted the CCE-411/metrics-test branch December 2, 2024 20:43
@tvoran tvoran added enhancement New feature or request injector metrics labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request injector metrics
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tvoran @benashz