diff --git a/ui/app/components/secret-engine/configuration-details.hbs b/ui/app/components/secret-engine/configuration-details.hbs index cfc7a2daf8a4..b7c0f703e359 100644 --- a/ui/app/components/secret-engine/configuration-details.hbs +++ b/ui/app/components/secret-engine/configuration-details.hbs @@ -12,9 +12,7 @@ @label={{or attr.options.label (to-label attr.name)}} @value={{get configModel (or attr.options.fieldValue attr.name)}} > - {{#if (or attr.options.sensitive (eq attr.name "publicKey"))}} - - {{/if}} + {{else}} attr.name); - return params.some((param) => this[param]); + // if every value is falsy, this engine has not been configured yet + return !this.configurableParams.every((param) => !this[param]); } // formFields are iterated through to generate the edit/create view diff --git a/ui/tests/acceptance/secrets/backend/azure/azure-configuration-test.js b/ui/tests/acceptance/secrets/backend/azure/azure-configuration-test.js index 3e69467be7a8..aea0f1956159 100644 --- a/ui/tests/acceptance/secrets/backend/azure/azure-configuration-test.js +++ b/ui/tests/acceptance/secrets/backend/azure/azure-configuration-test.js @@ -46,6 +46,11 @@ module('Acceptance | Azure | configuration', function (hooks) { await visit('/vault/settings/mount-secret-backend'); await mountBackend('azure', path); + assert.strictEqual( + currentURL(), + `/vault/secrets/${path}/configuration`, + 'navigated to configuration view' + ); assert.dom(GENERAL.emptyStateTitle).hasText('Azure not configured'); assert.dom(GENERAL.emptyStateActions).doesNotContainText('Configure Azure'); // cleanup @@ -56,11 +61,6 @@ module('Acceptance | Azure | configuration', function (hooks) { const path = `azure-${this.uid}`; await enablePage.enable('azure', path); assert.dom(SES.configure).doesNotExist('Configure button does not exist.'); - assert.strictEqual( - currentURL(), - `/vault/secrets/${path}/configuration`, - 'navigated to configuration view' - ); // cleanup await runCmd(`delete sys/mounts/${path}`); }); @@ -82,7 +82,6 @@ module('Acceptance | Azure | configuration', function (hooks) { }); await enablePage.enable(type, path); for (const key of expectedConfigKeys('azure-wif')) { - assert.dom(GENERAL.infoRowLabel(key)).exists(`${key} on the ${type} config details exists.`); const responseKeyAndValue = expectedValueOfConfigKeys(type, key); assert .dom(GENERAL.infoRowValue(key))